Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fix null pointer exception after all datafeed indices deleted #76401

Conversation

droberts195
Copy link
Contributor

A datafeed will not start running if no indices exist that match
the pattern it's configured to search. However, it is possible that
after the datafeed has started somebody could delete all the indices
that it is configured to search.

This change handles that situation more gracefully, avoiding
repeated logging of null pointer exceptions to the Elasticsearch log.

A datafeed will not start running if no indices exist that match
the pattern it's configured to search. However, it is possible that
after the datafeed has started somebody could delete all the indices
that it is configured to search.

This change handles that situation more gracefully, avoiding
repeated logging of null pointer exceptions to the Elasticsearch log.
@elasticmachine elasticmachine added the Team:ML Meta label for the ML team label Aug 12, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@droberts195 droberts195 added the auto-backport Automatically create backport pull requests when merged label Aug 12, 2021
Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@benwtrent benwtrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
7.14
7.x

droberts195 added a commit to droberts195/elasticsearch that referenced this pull request Aug 12, 2021
…lastic#76401)

A datafeed will not start running if no indices exist that match
the pattern it's configured to search. However, it is possible that
after the datafeed has started somebody could delete all the indices
that it is configured to search.

This change handles that situation more gracefully, avoiding
repeated logging of null pointer exceptions to the Elasticsearch log.
elasticsearchmachine pushed a commit that referenced this pull request Aug 12, 2021
…76401) (#76406)

A datafeed will not start running if no indices exist that match
the pattern it's configured to search. However, it is possible that
after the datafeed has started somebody could delete all the indices
that it is configured to search.

This change handles that situation more gracefully, avoiding
repeated logging of null pointer exceptions to the Elasticsearch log.
elasticsearchmachine pushed a commit that referenced this pull request Aug 12, 2021
…76401) (#76407)

A datafeed will not start running if no indices exist that match
the pattern it's configured to search. However, it is possible that
after the datafeed has started somebody could delete all the indices
that it is configured to search.

This change handles that situation more gracefully, avoiding
repeated logging of null pointer exceptions to the Elasticsearch log.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged >bug :ml Machine learning Team:ML Meta label for the ML team v7.14.1 v7.15.0 v8.0.0-alpha2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants